impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3253: Modify gen_build_version.sh to always output the right version
Date Tue, 29 Mar 2016 18:13:12 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-3253: Modify gen_build_version.sh to always output the right version
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2651/1/bin/gen_build_version.py
File bin/gen_build_version.py:

Line 84:   return IMPALA_BUILD_VERSION;
> I didn't know it was that smart. Works for me.
Yup, all hardcoded strings are put into the rodata section, so that it doesn't have to make
a different copy per operation on that string.


-- 
To view, visit http://gerrit.cloudera.org:8080/2651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie461110b6f8ca545f04ea33b7b502aea550b8551
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message