impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <>
Subject [Impala-CR](cdh5-trunk) IMPALA-3253: Modify to always output the right version
Date Tue, 29 Mar 2016 00:55:29 GMT
Sailesh Mukil has uploaded a new patch set (#3).

Change subject: IMPALA-3253: Modify to always output the right version

IMPALA-3253: Modify to always output the right version previously had a --noclean option which did not
overwrite the version information if it was already populated. Since
--noclean was the default option, it always never updated the version

This patch modifies to generate a
common/ instead of a common/version.h. Now,
common/version.h will be a part of the git repo and will not need to
be modified on every build. It declares the functions that will return
the build information. These functions will be defined in
common/ and the build information will change on every new

Since only the .cc file changes on every build, we will not incur a
highly noticable change in build times.

Change-Id: Ie461110b6f8ca545f04ea33b7b502aea550b8551
M be/.gitignore
M be/src/common/CMakeLists.txt
A be/src/common/version.h
M be/src/exec/
M be/src/exec/
M be/src/service/
M be/src/util/
M bin/
M bin/
9 files changed, 61 insertions(+), 38 deletions(-)

  git pull ssh:// refs/changes/51/2651/3
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie461110b6f8ca545f04ea33b7b502aea550b8551
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <>
Gerrit-Reviewer: Casey Ching <>
Gerrit-Reviewer: Sailesh Mukil <>

View raw message