impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3243: Delete unneeded code that doesn't work on RHEL 5
Date Mon, 28 Mar 2016 16:27:43 GMT
Hello Internal Jenkins, Alex Behm,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2626

to look at the new patch set (#3).

Change subject: IMPALA-3243: Delete unneeded code that doesn't work on RHEL 5
......................................................................

IMPALA-3243: Delete unneeded code that doesn't work on RHEL 5

The MaxCPUIndex() interface was added by Kudu, but the code that
initializes it doesn't work on RHEL 5. Impala doesn't depend on
MaxCpuIndex() at all, but the value is calculated and cached at startup
time so it still executes.  So, let's just delete this effectively
dead code that doesn't work on RHEL 5.

Change-Id: I82b71de60e5bf8abec18f981d13528991265908f
---
M be/src/gutil/sysinfo.cc
M be/src/gutil/sysinfo.h
2 files changed, 0 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/26/2626/3
-- 
To view, visit http://gerrit.cloudera.org:8080/2626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I82b71de60e5bf8abec18f981d13528991265908f
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins

Mime
View raw message