impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Huaisi Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2722: Free local allocations per row batch in non-partitioned AGG and HJ
Date Sun, 27 Mar 2016 16:59:03 GMT
Huaisi Xu has submitted this change and it was merged.

Change subject: IMPALA-2722: Free local allocations per row batch in non-partitioned AGG and
HJ
......................................................................


IMPALA-2722: Free local allocations per row batch in non-partitioned AGG and HJ

The fix of IMPALA-2612 added a test which verifies that the memory
limit is not exceeded for the given query if local allocations are
freed per processed row batch. The test fails when PHJ is disabled
as the same bug (of missing free calls to local allocations) also
exists in the non-partitioned counterpart of PAGG and PHJ. This
change fixes both non-partitioned AGG and HJ nodes so local
allocations are freed per row batch.

Change-Id: I9aec4d1fb4f8d52fcdf67f1ca545efa698764f84
Reviewed-on: http://gerrit.cloudera.org:8080/1569
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Reviewed-by: Dan Hecht <dhecht@cloudera.com>
Reviewed-by: Marcel Kornacker <marcel@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit ff75c9cde1f6554e7d7cef0b06af366eeabc0a1a)
Reviewed-on: http://gerrit.cloudera.org:8080/2637
Reviewed-by: anujphadke <aphadke@cloudera.com>
Tested-by: Huaisi Xu <hxu@cloudera.com>
---
M be/src/exec/aggregation-node.cc
M be/src/exec/hash-join-node.cc
2 files changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Huaisi Xu: Verified
  anujphadke: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/2637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9aec4d1fb4f8d52fcdf67f1ca545efa698764f84
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.2.0_5.4.x
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>

Mime
View raw message