impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Re-enable Kudu in build using client stubs when needed
Date Sat, 26 Mar 2016 00:26:51 GMT
Dan Hecht has posted comments on this change.

Change subject: Re-enable Kudu in build using client stubs when needed
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2585/5/be/src/exec/kudu-util.cc
File be/src/exec/kudu-util.cc:

Line 41:   return true;
this looks backwards.  how are you testing this change?


Line 52:      return Status::OK();
indentation glitch.


-- 
To view, visit http://gerrit.cloudera.org:8080/2585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bf1c964faf21722137adc4f7ba7f78654f0f712
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message