impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Upgrade LLVM to 3.8.0
Date Fri, 25 Mar 2016 21:59:22 GMT
Michael Ho has posted comments on this change.

Change subject: Upgrade LLVM to 3.8.0
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2486/4/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

Line 162: !maybe_file_buffer
> maybe_file_buffer == NULL
Nevermind. Looks like that's how ErrorOr<T> works.


Line 181: !maybe_module
> maybe_module == NULL
Nevermind. Looks like that's how ErrorOr<T> works.


-- 
To view, visit http://gerrit.cloudera.org:8080/2486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17d7afd05ad3b472a0bfe035bfc3daada5597b2d
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message