impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2466: Add more tests for the HDFS parquet scanner.
Date Thu, 24 Mar 2016 18:13:19 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-2466: Add more tests for the HDFS parquet scanner.
......................................................................


Patch Set 4:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/1500/4/testdata/LineItemMultiBlock/lineitem_one_rg.parquet
File testdata/LineItemMultiBlock/lineitem_one_rg.parquet:

> Let's rename this file to use row_group instead of rg as well (last one :) 
Done


http://gerrit.cloudera.org:8080/#/c/1500/4/testdata/bin/create-load-data.sh
File testdata/bin/create-load-data.sh:

Line 315:   hadoop fs -mkdir -p /test-warehouse/lineitem_multiblock_one_rg_parquet &&
\
> one_row_group (and below)
Done


http://gerrit.cloudera.org:8080/#/c/1500/4/testdata/datasets/functional/schema_constraints.csv
File testdata/datasets/functional/schema_constraints.csv:

Line 48: table_name:lineitem_multiblock_onerg, constraint:restrict_to, table_format:parquet/none/none
> one_row_group
Done


http://gerrit.cloudera.org:8080/#/c/1500/4/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

Line 245:     was read. If 'one_row_group' is True, then one scan range reads the data from
the
> nit: then one scan range is expected to read the data
Done


Line 342:   
> remove whitespace
Done. (finally)
Sorry about that.


-- 
To view, visit http://gerrit.cloudera.org:8080/1500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4faccd9ce3fad42402652c8f17d4e7aa3d593368
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message