impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Juan Yu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3038: Add multistream gzip/bzip2 test coverage
Date Thu, 24 Mar 2016 03:50:05 GMT
Juan Yu has posted comments on this change.

Change subject: IMPALA-3038: Add multistream gzip/bzip2 test coverage
......................................................................


Patch Set 6:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/2543/6/be/src/util/decompress-test.cc
File be/src/util/decompress-test.cc:

Line 221:     EXPECT_OK(Codec::CreateCompressor(&mem_pool_, true, format, &compressor));
> How about you move the CreateCompressor/Close calls into GenerateMultiStrea
Done


Line 253:     memset(&raw_input, 0, sizeof(raw_input));
> remove memset
Done


Line 259:     // pick random-size input data(~1MB), compress it, then concatenate those small
> How about: Repeatedly pick random-size input data, compress it, .... Also c
Done


Line 270:       int len = RAW_INPUT_SIZE - (rand() % 1024);
> Maybe make this (rand() % 512), len can be as low as 1 as-is. Also, maybe w
len will be between 1023K and 1024K
I just want to create different length of compressed streams. each stream has header and probably
stream end indicator. If we don't care about that. I can just repeatedly concatenate the same
compressed stream.


Line 285:   uint8_t input_[2 * 26 * 1024];
> nit: put a blank line above here
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b0e1971145dd457e71fc9c00ce7c06fff8dea88
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message