impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Re-enable Kudu in build using client stubs when needed
Date Wed, 23 Mar 2016 20:46:15 GMT
Casey Ching has uploaded a new patch set (#3).

Change subject: Re-enable Kudu in build using client stubs when needed
......................................................................

Re-enable Kudu in build using client stubs when needed

The stubs in Impala broke during the merge commit. This commit removes
the stubs in hopes of improving robustness of the build. The original
problem (Kudu clients are only available for some OSs) is now addressed
by moving the stubbing into a dummy Kudu client. The dummy client only
allows linking to succeed, if any client method is called, Impala will
crash. Before calling any such method, Kudu availability must be
checked.

Change-Id: I4bf1c964faf21722137adc4f7ba7f78654f0f712
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/common/global-flags.cc
M be/src/common/init.cc
M be/src/exec/CMakeLists.txt
M be/src/exec/data-sink.cc
M be/src/exec/exec-node.cc
M be/src/exec/kudu-scan-node-test.cc
M be/src/exec/kudu-scan-node.cc
M be/src/exec/kudu-scan-node.h
M be/src/exec/kudu-scanner.cc
M be/src/exec/kudu-table-sink-test.cc
M be/src/exec/kudu-table-sink.cc
M be/src/exec/kudu-table-sink.h
M be/src/exec/kudu-util.cc
M be/src/exec/kudu-util.h
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M common/thrift/generate_error_codes.py
A tests/custom_cluster/test_kudu_not_available.py
20 files changed, 134 insertions(+), 130 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/85/2585/3
-- 
To view, visit http://gerrit.cloudera.org:8080/2585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4bf1c964faf21722137adc4f7ba7f78654f0f712
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message