impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2466: Add more tests for the HDFS parquet scanner.
Date Wed, 23 Mar 2016 06:19:39 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-2466: Add more tests for the HDFS parquet scanner.
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/1500/2/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

Line 238:   def test_multiple_blocks_one_rg(self, vector):
> one_row_group
Done


Line 247:   def _multiple_blocks_helper(self, query, total_rows, one_rg=False, ranges_per_node=1):
> Can you add a brief comment summarizing what this function does?
Done


Line 248:     result = self.client.execute(query)
> Since this function makes assumptions about the query below, how about you 
Done


Line 250:     assert result.data[0] == total_rows
> Maybe rename total_rows to rows_in_table.
Done


Line 260:     assert len(num_row_groups_list) == len(scan_ranges_complete_list) == 4
> Personally I like this broken up into two asserts better (also I think this
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/1500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4faccd9ce3fad42402652c8f17d4e7aa3d593368
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message