impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Juan Yu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3038: Add multistream gzip/bzip2 test coverage
Date Wed, 23 Mar 2016 05:25:22 GMT
Juan Yu has posted comments on this change.

Change subject: IMPALA-3038: Add multistream gzip/bzip2 test coverage
......................................................................


Patch Set 4:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/2543/4/be/src/util/decompress-test.cc
File be/src/util/decompress-test.cc:

Line 161:       EXPECT_LE(total_output_produced, uncompressed_len);
> How about move this below L168, and then you can remove the else condition 
Done


Line 245:         compressed, uncompressed_len, uncompressed, false));
> Call StreamingDecompress() again with the rest of the data and expected_str
Done


Line 254:     *compressed_data = mem_pool_.Allocate(16 * 1024 * 1024 + 1);
> Let's make these constants, e.g.:
Done


Line 259:     uint8_t raw_input[1024 * 1024 + 1];
> Likewise define RAW_INPUT_SIZE = 1024 * 1024 or similar.
Done


Line 260:     memset(&raw_input, 0, sizeof(raw_input));
> Since you're setting all but the last byte below, I would change this to ra
Done


Line 263:       *ip++ = 'a' + rand() % 26;
> Instead of defining ip, you can use raw_input[i] (this is more idiomatic to
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b0e1971145dd457e71fc9c00ce7c06fff8dea88
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message