impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Juan Yu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3194: Allow queries materializing scalar type columns in RC_FILE
Date Wed, 23 Mar 2016 04:15:21 GMT
Juan Yu has posted comments on this change.

Change subject: IMPALA-3194: Allow queries materializing scalar type columns in RC_FILE
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2580/4/testdata/workloads/functional-planner/queries/PlannerTest/complex-types-file-formats.test
File testdata/workloads/functional-planner/queries/PlannerTest/complex-types-file-formats.test:

Line 137: id
> I think this test is correct. It shouldn't run because we materialize compl
you're right the test behaves correctly , I missed the t.a part earlier.
I think this test is misleading, it gives impression that select scalar column for RC is not
supported.


-- 
To view, visit http://gerrit.cloudera.org:8080/2580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a89b211bdc01f7e07497e293fafd75ccf0500fe
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message