impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Add AtomicInt32/AtomicInt64 typedefs
Date Tue, 22 Mar 2016 23:12:34 GMT
Hello Henry Robinson,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2601

to look at the new patch set (#3).

Change subject: Add AtomicInt32/AtomicInt64 typedefs
......................................................................

Add AtomicInt32/AtomicInt64 typedefs

Only certain primitive types can be used with AtomicInt<>, so let's
treat AtomicInt<> as an implementation detail and instead expose
typedefs for the Atomic integer sizes we support. Convert all decls to
use the new typedefs.

Change-Id: I8b91ba684aabc67ed1721c7b7320aa42049268c8
---
M be/src/common/atomic-test.cc
M be/src/common/atomic.h
M be/src/exec/hdfs-scan-node.h
M be/src/rpc/rpc-trace.h
M be/src/runtime/data-stream-recvr.h
M be/src/runtime/disk-io-mgr-internal.h
M be/src/runtime/disk-io-mgr-test.cc
M be/src/runtime/disk-io-mgr.h
M be/src/runtime/lib-cache.h
M be/src/runtime/mem-tracker.cc
M be/src/runtime/mem-tracker.h
M be/src/runtime/plan-fragment-executor.h
M be/src/scheduling/query-resource-mgr.cc
M be/src/scheduling/query-resource-mgr.h
M be/src/util/counting-barrier.h
M be/src/util/hdfs-bulk-ops.h
M be/src/util/internal-queue-test.cc
M be/src/util/periodic-counter-updater.h
M be/src/util/progress-updater.h
M be/src/util/runtime-profile.h
20 files changed, 64 insertions(+), 53 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/01/2601/3
-- 
To view, visit http://gerrit.cloudera.org:8080/2601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8b91ba684aabc67ed1721c7b7320aa42049268c8
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>

Mime
View raw message