impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Preview: Re-enable Kudu in build using client stubs when needed
Date Tue, 22 Mar 2016 00:39:29 GMT
Casey Ching has posted comments on this change.

Change subject: Preview: Re-enable Kudu in build using client stubs when needed
......................................................................


Patch Set 1:

> > Where's the corresponding Toolchain change to add the stubbed
 > > client?
 > 
 > I'm going to take your comments to mean you prefer to keep going
 > with this solution rather than sticking with what we have now. If
 > Matt agrees then I'll send out a better review.

Todd's generator is at https://gist.githubusercontent.com/toddlipcon/3c49366acb35e3fc3dec/raw/ff6ee2d4a42d0e6a6af10480fdce0823b0296327/gen-stub-so.py

I didn't make a patch for using it. But will do if needed.

-- 
To view, visit http://gerrit.cloudera.org:8080/2585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bf1c964faf21722137adc4f7ba7f78654f0f712
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message