impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] Support for building LLVM 3.7 and 3.8 on CentOS 5
Date Fri, 18 Mar 2016 23:21:11 GMT
Tim Armstrong has posted comments on this change.

Change subject: Support for building LLVM 3.7 and 3.8 on CentOS 5
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2546/3/source/llvm/build-source-tarball.sh
File source/llvm/build-source-tarball.sh:

Line 34:   tar xf ${THIS_DIR}/cfe-$PACKAGE_VERSION.src.tar.xz --use-compress-program xzcat
> Looks like xzcat isnt available by default on a mac. Maybe do a special cas
Done


Line 45:   # Skip this on Centos 5.8 since it depends on perf_event.h.
> Much better
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad649363fc64f30e0f17a9d51d7694a6fc00bc12
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message