impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] IMPALA-3191: toolchain components should use toolchain cmake
Date Fri, 18 Mar 2016 01:02:22 GMT
Matthew Jacobs has submitted this change and it was merged.

Change subject: IMPALA-3191: toolchain components should use toolchain cmake
......................................................................


IMPALA-3191: toolchain components should use toolchain cmake

The toolchain doesn't build on sles12. It appears to be a
cmake bug [1] though it hasn't been fixed yet upstream.

The cmake bug description mentions this workaround patching
cmake to avoid calling POSIX select(), and we should be
using the toolchain cmake to build toolchain components.

This also reverts the previous attempt to mitigate the issue
by avoiding bootstrapping cmake in parallel. That seemed to
help avoid the issue during bootstrapping, but the hang
could still occur later as well.

1: https://cmake.org/Bug/view.php?id=15873

Change-Id: I8a31098de42b4d5cb93c12bb2e054eadb8b8c72a
---
M buildall.sh
M init.sh
M source/cmake/build.sh
A source/cmake/cmake-3.2.3-patches/0001-IMPALA-3191.patch
M source/llvm/build-source-tarball.sh
M source/llvm/build-trunk.sh
6 files changed, 39 insertions(+), 21 deletions(-)

Approvals:
  Matthew Jacobs: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/2567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8a31098de42b4d5cb93c12bb2e054eadb8b8c72a
Gerrit-PatchSet: 5
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message