impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Skye Wanderman-Milne (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node
Date Fri, 18 Mar 2016 00:28:01 GMT
Skye Wanderman-Milne has posted comments on this change.

Change subject: IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node
......................................................................


Patch Set 8:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/1901/8/be/src/codegen/codegen-anyval.cc
File be/src/codegen/codegen-anyval.cc:

Line 585: WriteToSlot
> Have you considered refactoring the code so there is more sharing with Text
Hm, I'm not sure how to share code, but maybe you have some ideas? TextConverter::WriteSlot()/CodegenWriteSlot()
are mostly dealing with parsing string input and don't deal with AnyVals at all, but I could
be missing something.


Line 597:   // Create new block after conditional blocks if necessary
        :   if (insert_before == NULL) insert_before = BasicBlock::Create(context, "end_write",
fn);
> Just wondering why this statement isn't before the creation of the two basi
BasicBlock::Create() will insert a block at the end of the function if 'insert_before' is
NULL, so it doesn't matter where we create insert_before. I put it here so the blocks are
created in the order they appear in the IR, but I can see how this is confusing so I'll move
it above the "null"/"non_null" creation.


http://gerrit.cloudera.org:8080/#/c/1901/8/be/src/runtime/tuple.cc
File be/src/runtime/tuple.cc:

Line 331: >GetPtrType(
> Can you please update the patch to converge on using only one of GetPtrType
Ok. I was mixing these because I like Value::getPointerTo() better than codegen->GetPtrTo(Value*),
but I like codegen->GetPtrTo(string type_name) better than codegen->GetPtrTo(type_name)->getPointerTo().
I'll just use GetPtrType() here though.


http://gerrit.cloudera.org:8080/#/c/1901/8/be/src/runtime/tuple.h
File be/src/runtime/tuple.h:

Line 148: MemPool* pool,
> Can we drop this parameter and update CodegenMaterializeExprs() to generate
Done


Line 164: MemPool* pool,
> Can we drop this parameter ?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/1901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib422a8d50303c21c6a228675157bf867e8619444
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message