impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Skye Wanderman-Milne (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1702: Check duplicated table ID in tables without associated TupleDescriptors
Date Thu, 17 Mar 2016 23:18:42 GMT
Skye Wanderman-Milne has posted comments on this change.

Change subject: IMPALA-1702: Check duplicated table ID in tables without associated TupleDescriptors
......................................................................


Patch Set 2:

(1 comment)

What do you mean by check the source tbl_desc?

If you can find a place to check earlier so we can gather more information, go for it. I think
we should keep this check though because I think it's the only place where we know for sure
we have all the table descs collected.

http://gerrit.cloudera.org:8080/#/c/2570/2/fe/src/main/java/com/cloudera/impala/analysis/DescriptorTable.java
File fe/src/main/java/com/cloudera/impala/analysis/DescriptorTable.java:

Line 94:   public List<Table> getReferencedTable() { return referencedTables_; }
getReferencedTables()


-- 
To view, visit http://gerrit.cloudera.org:8080/2570
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2a6324cb9e28ba5be4bb525a639433ba3e8782b
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message