impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3141: Send full filters when filter production is disabled
Date Thu, 17 Mar 2016 23:13:51 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3141: Send full filters when filter production is disabled
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/2475/5/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 640:       int pending_count = state.completion_time != 0L ? 0 : state.pending_count;
> for debugging purposes, why not show the actual pending count (would be int
I did consider that, but I think that's better handled by asserts in the code. Otherwise we'll
confuse anyone who looks at this and thinks that filters aren't getting delivered.


Line 2005:     // offer it to the queue.
> dcheck(pending_count == 0)
Done


http://gerrit.cloudera.org:8080/#/c/2475/5/be/src/runtime/runtime-filter.cc
File be/src/runtime/runtime-filter.cc:

Line 142:       return;
> bypasses l149; use goto or add function RecordArrival(id) and call that eve
I think } else { and fall-through is simplest.


-- 
To view, visit http://gerrit.cloudera.org:8080/2475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04b3e6542651c1e7b77a9bab01d0e3d9506af42f
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message