impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <>
Subject [Toolchain-CR] Add binutils
Date Thu, 17 Mar 2016 21:35:27 GMT
Casey Ching has posted comments on this change.

Change subject: Add binutils

Patch Set 1:

Commit Message:

Line 10: has a little more detail.
> Put JIRA in first line?
I think that would be normal if that were a toolchain issue but it's an impala issue.

Line 166: #
> do we also want an option to use the system binutils?
I don't think so. Seems like having fewer variations is better.

Line 168: "
> we haven't been using quotes around $SOURCE_DIR elsewhere, is this better? 
In theory all paths should be quoted. But if even one of them is not quoted a bunch of stuff
could break. So in practice people make sure their paths work with unquoted vars.

Line 169:   # Add ld from binutils to the path so it'll be used.
> Should we use instead by default?
That can be done later if someone wants it. I'm thinking we'd use gcc's fuse-ld=gold option.

Line 170: PATH
> do you need to export PATH again?
File source/binutils/

Line 19: THIS_DIR="$(cd "$(dirname "$0")" && pwd)"
> How does this work with the nested quotes?
That's from Martin's scripts. I did a quick search online but didn't find a good explanation.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f6f0fea3d33872ee2c119fec824afbd7e09886e
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Casey Ching <>
Gerrit-Reviewer: Casey Ching <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message