impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] Add binutils
Date Thu, 17 Mar 2016 21:22:49 GMT
Matthew Jacobs has posted comments on this change.

Change subject: Add binutils
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/2575/1/init.sh
File init.sh:

Line 166: #
do we also want an option to use the system binutils?


Line 168: "
we haven't been using quotes around $SOURCE_DIR elsewhere, is this better? should we be using
this elsewhere or can we keep this consistent?


Line 170: PATH
do you need to export PATH again?


-- 
To view, visit http://gerrit.cloudera.org:8080/2575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f6f0fea3d33872ee2c119fec824afbd7e09886e
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message