impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] IMPALA-3191: toolchain components should use toolchain cmake
Date Thu, 17 Mar 2016 19:39:08 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3191: toolchain components should use toolchain cmake
......................................................................


Patch Set 3:

The issue with that is that it doesn't ensure cmake is built beforehand. I can change init.sh
to change the PATH if we prefer that to using $CMAKE_EXEC, but I wasn't sure if we should
pollute the path. I guess it's fine so I can make that change to this. I do think we should
be building it in init.sh though.

-- 
To view, visit http://gerrit.cloudera.org:8080/2567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a31098de42b4d5cb93c12bb2e054eadb8b8c72a
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message