impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1822: Cleanup query profile log
Date Thu, 17 Mar 2016 19:03:36 GMT
Hello Matthew Jacobs, Internal Jenkins, Sailesh Mukil, Dan Hecht,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2260

to look at the new patch set (#7).

Change subject: IMPALA-1822: Cleanup query profile log
......................................................................

IMPALA-1822: Cleanup query profile log

Implemented log rotation for the query profile log, to prevent it
from growing unbounded, by adding log rotation to the SimpleLogger
class.

Previously, log rotation was only enabled for glog. It is still not
enabled for audit event logging or lineage logging, but this should
be simple to fix as they both use the same SimpleLogger class that
the profile logging uses.

There is a new flag, max_profile_log_files that controls how many
of the most recent profile log files are retained.

Change-Id: I52430d192d27cdf9bc0d81f26a63048eaeec5d29
---
M be/src/common/logging.cc
M be/src/service/impala-server.cc
M be/src/util/CMakeLists.txt
A be/src/util/logging-support-test.cc
M be/src/util/logging-support.cc
M be/src/util/logging-support.h
M be/src/util/simple-logger.cc
M be/src/util/simple-logger.h
8 files changed, 187 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/60/2260/7
-- 
To view, visit http://gerrit.cloudera.org:8080/2260
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52430d192d27cdf9bc0d81f26a63048eaeec5d29
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>

Mime
View raw message