impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anuj Phadke (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1850 allow fs.defaultFS to be set to a non-HDFS filesystem
Date Thu, 17 Mar 2016 06:54:07 GMT
Anuj Phadke has posted comments on this change.

Change subject: IMPALA-1850 allow fs.defaultFS to be set to a non-HDFS filesystem
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/1121/9/bin/impala-config.sh
File bin/impala-config.sh:

Line 103: export FILESYSTEM_PREFIX="s3a://${S3_BUCKET}"
> Ah right, I missed that.
I removed the FILESYSTEM_PREFIX and I am able to run the tests without any failures.


http://gerrit.cloudera.org:8080/#/c/1121/9/tests/query_test/test_multiple_filesystems.py
File tests/query_test/test_multiple_filesystems.py:

Line 11: @SkipIfS3.insert
> You can ignore this comment too. We need to figure out a different way to r
Henry/Dan - Can I set FILESYSTEM_PREFIX to localFs at the start of this script and set it
back to the original value after executing this script? 
So once we have a fix for the s3 inserts we can run this on  local + S3?

@Sailesh - We can discuss this tomorrow


-- 
To view, visit http://gerrit.cloudera.org:8080/1121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed
Gerrit-PatchSet: 9
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Anuj Phadke <aphadke@cloudera.com>
Gerrit-Reviewer: Anuj Phadke <aphadke@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message