impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1850 allow fs.defaultFS to be set to a non-HDFS filesystem
Date Wed, 16 Mar 2016 00:18:22 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-1850 allow fs.defaultFS to be set to a non-HDFS filesystem
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1121/9/bin/impala-config.sh
File bin/impala-config.sh:

Line 103: export FILESYSTEM_PREFIX="s3a://${S3_BUCKET}"
> To address Henry's comment (on this line in patch set 6), you can do the fo
I don't think we should set FILESYSTEM_PREFIX if we're going to run S3 by setting defaultFS.
 The point of defaultFS is so you don't need to qualify the paths.


-- 
To view, visit http://gerrit.cloudera.org:8080/1121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed
Gerrit-PatchSet: 9
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Anuj Phadke <aphadke@cloudera.com>
Gerrit-Reviewer: Anuj Phadke <aphadke@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message