impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3141: Send full filters when filter production is disabled
Date Tue, 15 Mar 2016 21:16:14 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-3141: Send full filters when filter production is disabled
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2475/3/be/src/util/bloom-filter.cc
File be/src/util/bloom-filter.cc:

Line 31:       // are 64 = 2^6 bytes in a cache line.
> Not sure exactly what you want asserted - that 1 << LOG_BUCKET_WORD_BITS ==
no, that our cache lines are indeed 64 bytes. i guess there's no compile time constant for
that, so what you have in cpu-util.cc is fine.


-- 
To view, visit http://gerrit.cloudera.org:8080/2475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04b3e6542651c1e7b77a9bab01d0e3d9506af42f
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message