impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] Download GCC deps from S3, not gnu.org
Date Tue, 15 Mar 2016 21:03:06 GMT
Casey Ching has posted comments on this change.

Change subject: Download GCC deps from S3, not gnu.org
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2553/1/source/gcc/build.sh
File source/gcc/build.sh:

Line 33:   download_dependency $LPACKAGE "mpfr-${MPFR_VERSION}.tar.bz2" $THIS_DIR
       :   tar xjf "../mpfr-${MPFR_VERSION}.tar.bz2"
       :   ln -s mpfr-${MPFR_VERSION} mpfr
Are these paths correct? This doesn't read well... it looks like something is being downloaded
to the current dir, but somehow actually ends up in the parent dir, then somehow the thing
that got extracted ended up in the current dir?


-- 
To view, visit http://gerrit.cloudera.org:8080/2553
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I810b8debe91a1450c05f5cff39e885c95a6632f0
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message