impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Address last few review items on the impala-kudu merge
Date Tue, 15 Mar 2016 05:41:00 GMT
Casey Ching has posted comments on this change.

Change subject: Address last few review items on the impala-kudu merge
......................................................................


Patch Set 1:

(1 comment)

I'm still not so sure about keeping deploy.py. Do you happen to know if it's the same as https://github.com/cloudera/impala-kudu/blob/feature/kudu/infra/deploy/deploy.py
? Seems bad to have two of them.

http://gerrit.cloudera.org:8080/#/c/2545/1/infra/deploy/deploy.py
File infra/deploy/deploy.py:

Line 3: # Confidential Cloudera Information: Covered by NDA.
This line should be removed.


-- 
To view, visit http://gerrit.cloudera.org:8080/2545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc4b30180a8f23394c7afc32b32668b05f142eff
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: David Ribeiro Alves <david.alves@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message