impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Reduce dependencies on inline header functions
Date Tue, 15 Mar 2016 03:22:59 GMT
Tim Armstrong has posted comments on this change.

Change subject: Reduce dependencies on inline header functions
......................................................................


Patch Set 3:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/2485/3/be/src/exec/hdfs-text-scanner.cc
File be/src/exec/hdfs-text-scanner.cc:

Line 26: #include "runtime/runtime-filter.inline.h"
> May be I missed it but doesn't seem to see any reference to RunTimeFilter i
Done


http://gerrit.cloudera.org:8080/#/c/2485/3/be/src/exec/partitioned-aggregation-node.cc
File be/src/exec/partitioned-aggregation-node.cc:

Line 41: #include "util/bloom-filter.h"
> Is this actually needed ?
Done


http://gerrit.cloudera.org:8080/#/c/2485/3/be/src/exec/partitioned-hash-join-node.cc
File be/src/exec/partitioned-hash-join-node.cc:

Line 31: #include "runtime/runtime-filter.inline.h"
> Is this for RegisterFilter() only ? If so, should we #include runtime-filte
Done. Needed to add util/bloom-filter.h too


http://gerrit.cloudera.org:8080/#/c/2485/3/be/src/runtime/buffered-tuple-stream.cc
File be/src/runtime/buffered-tuple-stream.cc:

Line 23: runtime/string-value.inline.h"
> Would #include "runtime/string-value.h" be sufficient ?
Done


http://gerrit.cloudera.org:8080/#/c/2485/3/be/src/runtime/raw-value.inline.h
File be/src/runtime/raw-value.inline.h:

Line 32: inline bool RawValue::Eq(const void* v1, const void* v2, const ColumnType& type)
{
> Don't we only call this for interpretation ? Normally, we would use the cod
You're right now that TupleRowComparator is codegened. I'll move it to the .cc unless anyone
has objections.


Line 336: RawValue::PrintValue
> Do you know why only this version of PrintValue() is inlined ? It seems to 
Looks like that's the case: I did a git blame and the commit that moved it to the header file
claims "On lineitem, this changes time from ~65sec to 25sec."

I'm confused why this would improve performance that much too.


-- 
To view, visit http://gerrit.cloudera.org:8080/2485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7a2f388cd14a4427c43af2724340a2ffe8fae3d
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message