impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Skye Wanderman-Milne (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2069: add USE_UTF8_PARQUET_STRINGS query option
Date Mon, 14 Mar 2016 23:51:09 GMT
Skye Wanderman-Milne has posted comments on this change.

Change subject: IMPALA-2069: add USE_UTF8_PARQUET_STRINGS query option
......................................................................


Patch Set 1:

(1 comment)

Changing the default would break any existing workloads where the files' field names don't
match the table's column names.

http://gerrit.cloudera.org:8080/#/c/2531/1/be/src/exec/hdfs-parquet-table-writer.h
File be/src/exec/hdfs-parquet-table-writer.h:

Line 134:   bool use_utf8_strings_;
> why not just use the query option directly?
I originally imagined being able to toggle this via query option or startup flag, but it will
take more work to get the query option default to correspond to the startup flag. I'll get
rid of it.


-- 
To view, visit http://gerrit.cloudera.org:8080/2531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I030c9f5c6272e09c1ce133f66234e3cfb26b68d4
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message