impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Reduce dependencies on inline header functions
Date Mon, 14 Mar 2016 22:55:14 GMT
Tim Armstrong has posted comments on this change.

Change subject: Reduce dependencies on inline header functions
......................................................................


Patch Set 6:

(7 comments)

I necromanced an old version of the patch, which is why some stuff I claimed to have deleted
came back.

http://gerrit.cloudera.org:8080/#/c/2485/6/be/src/exprs/timestamp-functions.h
File be/src/exprs/timestamp-functions.h:

Line 112:   static std::string ShortMonthName(FunctionContext* context, const TimestampVal&
ts);
> How did it compiles without the std:: before?
Some of the gutil headers have 'using std::string' in them, so I guess through that maybe?


http://gerrit.cloudera.org:8080/#/c/2485/6/be/src/runtime/decimal-value.h
File be/src/runtime/decimal-value.h:

Line 55:   static DecimalValue FromDouble(int precision, int scale, double d, bool* overflow);
> Mark inline? here and below
Done


http://gerrit.cloudera.org:8080/#/c/2485/6/be/src/runtime/raw-value.h
File be/src/runtime/raw-value.h:

Line 106
I also marked the declarations of these functions as inline (the error message is less confusing
if you miss the include in this case).


http://gerrit.cloudera.org:8080/#/c/2485/6/be/src/runtime/runtime-filter.h
File be/src/runtime/runtime-filter.h:

Line 84:   const RuntimeFilter* GetRuntimeFilter(uint32_t filter_id);
> Mark inline? here and below
Done


http://gerrit.cloudera.org:8080/#/c/2485/6/be/src/runtime/timestamp-parse-util.cc
File be/src/runtime/timestamp-parse-util.cc:

Line 17: #include <cstddef>
> Remove if unnececssary
Done


http://gerrit.cloudera.org:8080/#/c/2485/6/be/src/runtime/timestamp-parse-util.h
File be/src/runtime/timestamp-parse-util.h:

Line 163:   static DateTimeFormatContext* CreateFormatContext();
> You didn't actually delete these :)
Done


http://gerrit.cloudera.org:8080/#/c/2485/6/be/src/runtime/timestamp-test.cc
File be/src/runtime/timestamp-test.cc:

Line 16: #include <cstddef>
> Remove here too if unnecessary
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7a2f388cd14a4427c43af2724340a2ffe8fae3d
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message