impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-CR](cdh5-trunk) Reduce dependencies on inline header functions
Date Mon, 14 Mar 2016 22:55:14 GMT
Tim Armstrong has posted comments on this change.

Change subject: Reduce dependencies on inline header functions

Patch Set 6:


I necromanced an old version of the patch, which is why some stuff I claimed to have deleted
came back.
File be/src/exprs/timestamp-functions.h:

Line 112:   static std::string ShortMonthName(FunctionContext* context, const TimestampVal&
> How did it compiles without the std:: before?
Some of the gutil headers have 'using std::string' in them, so I guess through that maybe?
File be/src/runtime/decimal-value.h:

Line 55:   static DecimalValue FromDouble(int precision, int scale, double d, bool* overflow);
> Mark inline? here and below
File be/src/runtime/raw-value.h:

Line 106
I also marked the declarations of these functions as inline (the error message is less confusing
if you miss the include in this case).
File be/src/runtime/runtime-filter.h:

Line 84:   const RuntimeFilter* GetRuntimeFilter(uint32_t filter_id);
> Mark inline? here and below
File be/src/runtime/

Line 17: #include <cstddef>
> Remove if unnececssary
File be/src/runtime/timestamp-parse-util.h:

Line 163:   static DateTimeFormatContext* CreateFormatContext();
> You didn't actually delete these :)
File be/src/runtime/

Line 16: #include <cstddef>
> Remove here too if unnecessary

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7a2f388cd14a4427c43af2724340a2ffe8fae3d
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Skye Wanderman-Milne <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message