impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1903: Add support for partitioning by TIMESTAMP
Date Mon, 14 Mar 2016 21:49:10 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-1903: Add support for partitioning by TIMESTAMP
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1621/3/be/src/exprs/expr.cc
File be/src/exprs/expr.cc:

Line 209: else {
        :         *expr = pool->Add(new NullLiteral(texpr_node));
        :       }
> Sorry my bad. What if you put the cast in the select list?
Then it adds the data from the "invalid" row to the null partition, located in hdfs://.../$PARTITION_COLUMN_NAME=__HIVE_DEFAULT_PARTITION__


-- 
To view, visit http://gerrit.cloudera.org:8080/1621
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icad7dcdc1b199cce9483dc414072bbe24efd625c
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message