impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3183: clang doesn't allow C files to have -std=c++14
Date Mon, 14 Mar 2016 21:21:27 GMT
Hello Matthew Jacobs,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2540

to look at the new patch set (#2).

Change subject: IMPALA-3183: clang doesn't allow C files to have -std=c++14
......................................................................

IMPALA-3183: clang doesn't allow C files to have -std=c++14

Using the same workaround we used for IMPALA-2845 (rune.c): Rename the
.c to .cc, and put extern "C" around it.

Testing:
 - make_asan.sh and run some queries
 - make_debug.sh and run some queries

Change-Id: I1dc8723214ec157aa7dc870d463294da4c754df2
---
M be/src/gutil/CMakeLists.txt
R be/src/gutil/dynamic_annotations.cc
2 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/40/2540/2
-- 
To view, visit http://gerrit.cloudera.org:8080/2540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1dc8723214ec157aa7dc870d463294da4c754df2
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message