impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3132: link ImpalaUdf first in UDF tests
Date Sat, 12 Mar 2016 02:50:15 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3132: link ImpalaUdf first in UDF tests
......................................................................


IMPALA-3132: link ImpalaUdf first in UDF tests

ImpalaUdf provides test implementations of MemTracker, FreePool, and
RuntimeState for use with UDF tests. We attempted to link these test
definitions in udf-test, uda-test, and aggregate-functions-test by
replacing the Udf lib dependency with ImpalaUdf. While this caused us
to use the correct compiled version of udf.cc, the linker would still
use the Runtime implementations of the class methods rather than the
ImpalaUdf definitions, since Runtime case first in the link order.

This patch addresses this by making ImpalaUdf the first linked lib for
UDF tests (and as a result we no longer need to remove the Udf
lib). It also adds calls to InitCommonRuntime() in the affected tests
so their output isn't redirected by default.

Ideally the UDF tests wouldn't need to depend on Runtime at all (or
specifically the parts redefined by ImpalaUdf), but it will require
major refactoring to make this possible.

Change-Id: I619c9e708794aaf1138bdc0087fbe82539c0817e
Reviewed-on: http://gerrit.cloudera.org:8080/2471
Reviewed-by: Marcel Kornacker <marcel@cloudera.com>
Tested-by: Internal Jenkins
---
M be/CMakeLists.txt
M be/src/exprs/CMakeLists.txt
M be/src/exprs/aggregate-functions-test.cc
M be/src/udf/CMakeLists.txt
M be/src/udf/uda-test.cc
M be/src/udf/udf-test.cc
6 files changed, 26 insertions(+), 19 deletions(-)

Approvals:
  Marcel Kornacker: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/2471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I619c9e708794aaf1138bdc0087fbe82539c0817e
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>

Mime
View raw message