impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Huaisi Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3045: Allow user defined package root.
Date Sat, 12 Mar 2016 00:47:18 GMT
Huaisi Xu has posted comments on this change.

Change subject: IMPALA-3045: Allow user defined package root.
......................................................................


Patch Set 1:

glad you are interested in this patch!
I think the 2,3 step is included in make_debug and buildall.
and you must update the package version in impala-config as well. i.e. p2 to p3 if you are
building p3.
and also set IMPALA_{package}_ROOT to your own package's root.

One problem of this is that the script will never know where is our modified tool chain directory.
It does not assume to be the same as $IMPALA_TOOLCHAIN. If we can make this assumption then
the integration will be better, can we?

-- 
To view, visit http://gerrit.cloudera.org:8080/2263
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d5a76fcec0c6e50fbbbba05c25f9252e092c063
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message