impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <>
Subject [Impala-CR](cdh5-trunk) IMPALA-1903: Add support for partitioning by TIMESTAMP
Date Fri, 11 Mar 2016 20:36:27 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-1903: Add support for partitioning by TIMESTAMP

Patch Set 5:


Minor comments. The main issue left is the behavior when invalid timestamp values are used.
Commit Message:

Line 17: it missing
nit: "is" is missing :)
File be/src/exprs/

Line 5509: TestValue("nonnullvalue(cast('2010-01-01' as timestamp))", TYPE_BOOLEAN, true);
For completion, let's also add one timestamp with date and time but without the fractional
File be/src/runtime/timestamp-parse-util.h:

Line 359: CheckParse
Or maybe ParseTimestamp?
File common/thrift/Types.thrift:

Line 24: unrelated enums
Such as?
File fe/src/main/java/com/cloudera/impala/analysis/

Line 126: result = new TimestampLiteral(exprNode.timestamp_literal.value);
Why don't you call the LiteralExpr.create() as we do in the other cases?
File fe/src/main/java/com/cloudera/impala/analysis/

Line 84: public int compareTo(LiteralExpr o)
As we discussed offline, let's remove this.
File fe/src/main/java/com/cloudera/impala/catalog/

Line 278: if (!isSupported() || isComplexType()) {
        :       return false;
        :     }
nit: single line
File fe/src/main/java/com/cloudera/impala/planner/

Line 136: // TODO: we support DECIMAL but no way to specify it in SQL.
I am not sure I understand what this TODO means. Can you check with Alex or maybe MJ?
File fe/src/test/java/com/cloudera/impala/analysis/

Line 1262: 
nit: remove empty line
File testdata/workloads/functional-query/queries/QueryTest/timestamp-partitions.test:

Line 29: select * from t
       : where ts != '1999-12-31';
If they fit, can you put each statement in a single line?
File tests/metadata/

Line 209:  
nit: extra space

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Icad7dcdc1b199cce9483dc414072bbe24efd625c
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-HasComments: Yes

View raw message