impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3114: Add a pause monitor for impala processes.
Date Fri, 11 Mar 2016 18:36:30 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3114: Add a pause monitor for impala processes.
......................................................................


Patch Set 4:

(5 comments)

lgtm modulo these few nits, but Dan or Marcel have to give the +2.

http://gerrit.cloudera.org:8080/#/c/2405/4//COMMIT_MSG
Commit Message:

Line 10: every
not 'every', 'for'


Line 11: 10seconds
10 seconds (or just 10s)


http://gerrit.cloudera.org:8080/#/c/2405/4/be/src/common/init.cc
File be/src/common/init.cc:

Line 85: A single
       : // thread is spawn that
just say 'The thread'


Line 141:   while(true) {
space before (


Line 142: int64_t start = last_end_time;
I think you can just use one variable here:

  int64_t time_before_sleep = MonotonicMillis()
  while (true) {
    SleepForMs(...)
    int64_t sleep_time = MonotonicMillis() - time_before_sleep;
    time_before_sleep += sleep_time;
    if (sleep_time ... ) { }
  }


-- 
To view, visit http://gerrit.cloudera.org:8080/2405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04eca63c0c44fa8f1b78833080acdc2176372263
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message