impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcell Szabo (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2518: DROP DATABASE CASCADE does not remove cache directives of tables
Date Fri, 11 Mar 2016 15:52:14 GMT
Marcell Szabo has posted comments on this change.

Change subject: IMPALA-2518: DROP DATABASE CASCADE does not remove cache directives of tables
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/1966/5/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java
File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java:

Line 1183: Does not update partition metadata because it expects the table/partitions to be
         :    * dropped immediately before/after this call.
> The table has already been dropped when this function is called. The commen
Done


Line 1187: { return; }
> formatting: remove { }
Done


http://gerrit.cloudera.org:8080/#/c/1966/5/fe/src/main/java/com/cloudera/impala/util/HdfsCachingUtil.java
File fe/src/main/java/com/cloudera/impala/util/HdfsCachingUtil.java:

Line 124: Removes the cache directive associated with the table from HDFS, uncaching all
        :    * data for non-partitioned table. Also updates the table's metadata.
        :    * No-op if the table is not cached.
        :    * If the table has partitions, uncachePartition() needs to be called.
> Why did you modify this comment? Where does this function check that this i
The original read: "uncaching all data" which is only true if the table is not partitioned.
If table is partitioned, then uncachePartition() needs to be called for each partition instead
of uncacheTbl() on the table.


-- 
To view, visit http://gerrit.cloudera.org:8080/1966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58270e1be49e71a08e12021e7dddab01969d1810
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Marcell Szabo <szama@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Marcell Szabo <szama@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message