impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcell Szabo (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2518: DROP DATABASE CASCADE does not remove cache directives of tables
Date Fri, 11 Mar 2016 15:51:44 GMT
Marcell Szabo has posted comments on this change.

Change subject: IMPALA-2518: DROP DATABASE CASCADE does not remove cache directives of tables
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1966/3/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java
File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java:

Line 1175: if (table.getNumClusteringCols() > 0) {
> Why is that?
Because I prefer structured programming. An indentation level is a visual cue for identifying
a block of code that might not run depending on conditions. A return statement is harder to
spot and increases chance of messing up logic during refactor.
But probably this is not the most important thing to decide about Impala, so either is good
for me.


-- 
To view, visit http://gerrit.cloudera.org:8080/1966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58270e1be49e71a08e12021e7dddab01969d1810
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Marcell Szabo <szama@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Marcell Szabo <szama@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message