impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Stress test: Fix stack trace collection
Date Thu, 10 Mar 2016 21:49:55 GMT
Casey Ching has submitted this change and it was merged.

Change subject: Stress test: Fix stack trace collection
......................................................................


Stress test: Fix stack trace collection

A lot of stuff got messed up during the switch to the cluster model...

Changes:
1) find_crashed_impalads() returned a list but the caller expected a
   dict.
2) for_each_impalad() ignored the parameter 'impalads' and instead used
   all impalads in the cluster.
3) find_last_backtrace() returned the oldest core dump instead of the
   newest.
4) num_successive_errors_needed_to_abort was effectively hard-coded to
   2. I'm not sure how that happened.
5) Catch EOFError when getting a query from the work queue. This happens
   when the work queue is shutdown but there are workers waiting for an
   item.
6) Ignore connection errors due to an unresponsive impalad. When the
   load on an impalad get very high it randomly stops responding to
   client requests. Reducing the load seems to help.
7) Added various log messages.

Change-Id: Icb823dc47a51874b0f8a0b20f966a556752f7796
Reviewed-on: http://gerrit.cloudera.org:8080/2176
Reviewed-by: Casey Ching <casey@cloudera.com>
Tested-by: Casey Ching <casey@cloudera.com>
---
M tests/comparison/cluster.py
M tests/stress/concurrent_select.py
2 files changed, 40 insertions(+), 14 deletions(-)

Approvals:
  Casey Ching: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/2176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb823dc47a51874b0f8a0b20f966a556752f7796
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message