impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Remove AMD Opteron Rev E workaround from atomicops
Date Thu, 10 Mar 2016 19:27:11 GMT
Hello Michael Ho, Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2516

to look at the new patch set (#2).

Change subject: Remove AMD Opteron Rev E workaround from atomicops
......................................................................

Remove AMD Opteron Rev E workaround from atomicops

Impala doesn't run on Opteron Rev E because those CPUs don't support
SSSE3.  So let's not pay the price of this cmp/branch on the atomics
path (which is used by our SpinLock, and I plan to make our Atomic class
use these functions in a future change).

Note that gperfutil also removed this RevE workaround since these CPUs
are getting old and apparently many kernels don't have the workaround
anyway.

Let's call the init function for atomicops, even though it's basically a
no-op for 64-bit mode (since these features are always available). But
this future proofs the code a bit better.

Change-Id: I3639dcf86c14778967c0079b8dbc222a4516cf05
---
M be/src/common/init.cc
M be/src/gutil/atomicops-internals-x86.cc
M be/src/gutil/atomicops-internals-x86.h
3 files changed, 3 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/16/2516/2
-- 
To view, visit http://gerrit.cloudera.org:8080/2516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3639dcf86c14778967c0079b8dbc222a4516cf05
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message