impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3136: Use gutil SpinLock
Date Thu, 10 Mar 2016 02:31:05 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3136: Use gutil SpinLock
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2507/6/be/src/gutil/atomicops-internals-x86.h
File be/src/gutil/atomicops-internals-x86.h:

Line 27: #include "common/logging.h"
Tim, I happened to notice the IR build was generating errors (multiple DCHECK* defs) so changed
this line.  Could you take a look?

Also, any reason we didn't promote warnings to errors during the cross compile?


-- 
To view, visit http://gerrit.cloudera.org:8080/2507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1e5322df1d5936ee9679cdc0031772b5f44b135
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message