impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3136: Use gutil SpinLock
Date Wed, 09 Mar 2016 23:38:31 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3136: Use gutil SpinLock
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2507/4/be/src/gutil/dynamic_annotations.h
File be/src/gutil/dynamic_annotations.h:

Line 399: LLVM_ENABLE_THREADS == 0
let me know if you think of a better way to deal with this. the problem was incompatible decls
for AnnotateIgnoreReadsBegin/AnnotateIgnoreReadsEnd, which also appear in Valgrind.h in llvm
headers that we sometimes include.


-- 
To view, visit http://gerrit.cloudera.org:8080/2507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1e5322df1d5936ee9679cdc0031772b5f44b135
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message