impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2502: don't redundantly repartition grouping aggregations
Date Wed, 09 Mar 2016 22:13:52 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-2502: don't redundantly repartition grouping aggregations
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2414/7/testdata/workloads/functional-planner/queries/PlannerTest/aggregation.test
File testdata/workloads/functional-planner/queries/PlannerTest/aggregation.test:

Line 1066: select straight_join coalesce(l_orderkey, 123), count(*)
> I added some logging. In the second query it's comparing:
I also dumped equivClassSmap and it looks like every expression is in its own class:

smap(tpch_parquet.lineitem.l_orderkey:tpch_parquet.lineitem.l_orderkey (SlotRef{path=l_orderkey,
type=BIGINT, id=0}:SlotRef{path=l_orderkey, type=BIGINT, id=0}) tpch_parquet.orders.o_orderkey:tpch_parquet.orders.o_orderkey
(SlotRef{path=o_orderkey, type=BIGINT, id=1}:SlotRef{path=o_orderkey, type=BIGINT, id=1})
ifnull(o_orderkey, 20):ifnull(o_orderkey, 20) (SlotRef{type=BIGINT, id=2}:SlotRef{type=BIGINT,
id=2}) count(*):count(*) (SlotRef{type=BIGINT, id=3}:SlotRef{type=BIGINT, id=3}))
I0309 14:11:59.252164 28373 Planner.java:124] desctbl: tuples:


-- 
To view, visit http://gerrit.cloudera.org:8080/2414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iffdcfd3629b8a69bd23915e1adba3b8323cbbaef
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message