impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2518: DROP DATABASE CASCADE does not remove cache directives of tables
Date Wed, 09 Mar 2016 18:02:09 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-2518: DROP DATABASE CASCADE does not remove cache directives of tables
......................................................................


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/1966/5/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java
File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java:

Line 1183: Does not update partition metadata because it expects the table/partitions to be
         :    * dropped immediately before/after this call.
The table has already been dropped when this function is called. The comment is not consistent
with the way this function is being used. Maybe just comment that this function does not update
table/partition metadata.


Line 1187: { return; }
formatting: remove { }


http://gerrit.cloudera.org:8080/#/c/1966/5/fe/src/main/java/com/cloudera/impala/util/HdfsCachingUtil.java
File fe/src/main/java/com/cloudera/impala/util/HdfsCachingUtil.java:

Line 124: Removes the cache directive associated with the table from HDFS, uncaching all
        :    * data for non-partitioned table. Also updates the table's metadata.
        :    * No-op if the table is not cached.
        :    * If the table has partitions, uncachePartition() needs to be called.
Why did you modify this comment? Where does this function check that this is an unpartitioned
table? I think the comment is confusing now.


http://gerrit.cloudera.org:8080/#/c/1966/5/testdata/workloads/functional-query/queries/QueryTest/hdfs-caching-minimal.test
File testdata/workloads/functional-query/queries/QueryTest/hdfs-caching-minimal.test:

Line 1: ====
I am not sure I understand why we need this test file. Aren't these test cases already covered
in hdfs-caching test? You simply want to test that drop database cascade uncaches all tables
under the deleted db. I'd recommend you just create a table in python, cache it and then drop
the database while verifying that the cache entries have been updated.


-- 
To view, visit http://gerrit.cloudera.org:8080/1966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58270e1be49e71a08e12021e7dddab01969d1810
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Marcell Szabo <szama@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Marcell Szabo <szama@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message