impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anuj Phadke (Code Review)" <>
Subject [Impala-CR](cdh5-trunk) IMPALA-1850 allow fs.defaultFS to be set to a non-HDFS filesystem
Date Wed, 09 Mar 2016 08:04:08 GMT
Anuj Phadke has posted comments on this change.

Change subject: IMPALA-1850 allow fs.defaultFS to be set to a non-HDFS filesystem

Patch Set 6:

Commit Message:

Line 11: required only if a datanode co-exists
> This comment doesn't match the code change.  And this looks more like IMPAL
Yes. Since the co-located data node changes have been moved to CM, I removed the function
to check for co-located datanodes.
This change basically whitelists the supported file systems and changes the behavior of S3
job to run solely on S3 now.
File tests/query_test/

Line 14: class TestMultipleFilesystems(ImpalaTestSuite):
> I think this means we completely loose coverage of this test.  we need to f
This change only starts S3. hdfs is not started anymore.
This test runs queries on tables that span multiple filesystems. we probably need  both to
run these tests

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Anuj Phadke <>
Gerrit-Reviewer: Anuj Phadke <>
Gerrit-Reviewer: Casey Ching <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Juan Yu <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-HasComments: Yes

View raw message