impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Reduce size of cross-compiled IR
Date Tue, 08 Mar 2016 21:28:36 GMT
Hello Skye Wanderman-Milne, Alex Behm, Dan Hecht,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2464

to look at the new patch set (#5).

Change subject: Reduce size of cross-compiled IR
......................................................................

Reduce size of cross-compiled IR

Disable the instnamer pass to reduce bitcode file size. Enable
inlining with a low threshold to inline many trivial functions in
the cross-compiled IR (e.g. scoped_ptr accessor functions).
Add additional IR_ALWAYS_INLINE annotations to trivial functions
that are called on hot paths.

This means that the functions will be inlined at compile time and
codegen has to do less work at runtime.

The IR module size is reduced from ~1.9MB to ~1.4MB with this
change and codegen time is slightly reduced. The number of functions is
reduced from 5698 to 3883.

Change-Id: Iea04ad2e4b365564ee71082657262485d3a85446
---
M be/CMakeLists.txt
M be/src/codegen/CMakeLists.txt
M be/src/common/compiler-util.h
M be/src/common/status.h
M be/src/exec/hash-table.h
M be/src/exec/partitioned-hash-join-node.h
M be/src/runtime/row-batch.h
M be/src/runtime/tuple-row.h
8 files changed, 58 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/64/2464/5
-- 
To view, visit http://gerrit.cloudera.org:8080/2464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea04ad2e4b365564ee71082657262485d3a85446
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message