impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-561: Allow multiple callbacks in a thread resource pool.
Date Tue, 08 Mar 2016 18:55:09 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-561: Allow multiple callbacks in a thread resource pool.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2430/2/be/src/exec/hdfs-scan-node.cc
File be/src/exec/hdfs-scan-node.cc:

Line 985: pool->ReleaseThreadToken(false);
> We were missing a call to release thread token here (see TryAcquireThreadTo
Oh I see, sorry I just wasn't expecting this here. I was distracted by this being Llama-related
code ("QueryResourceMgr" is for Llama/YARN integration), which is more or less dead code and
most likely will be removed or changed significantly. Makes sense.


-- 
To view, visit http://gerrit.cloudera.org:8080/2430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddfff1feef0b59d407994ad3bc560166acbfa623
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message