impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2626: In-flight queries fail when statestore comes back online.
Date Tue, 08 Mar 2016 00:04:38 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-2626: In-flight queries fail when statestore comes back online.
......................................................................


Patch Set 1:

(1 comment)

I think this only fixes a particular instance of the problem: if the statestore hasn't yet
got updates from all the subscribers, it will send a partial update which will have roughly
the same effect (since most queries run on all machines).

Doesn't the statestore give a list of deletions with an update? Presumably if it restarts,
it won't send deletions for any entries because it never knew they existed. The subscriber
could only cancel queries on nodes for which there is an actual deletion (i.e. the node was
known to have failed), but not include the missing nodes in any new scheduling decisions.

http://gerrit.cloudera.org:8080/#/c/1380/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

Line 1377:     if (!delta.is_delta) {
prefer 

  !delta.is_delta && delta.topic_entries.size() > 0


-- 
To view, visit http://gerrit.cloudera.org:8080/1380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I102391ab63270a9686cf45457b8384ffcd2abe8a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message