impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3114: Add a pause monitor for impala processes.
Date Mon, 07 Mar 2016 23:54:28 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3114: Add a pause monitor for impala processes.
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/2405/3/be/src/common/init.cc
File be/src/common/init.cc:

Line 141: int64_t start = MonotonicMillis();
I think you should just use the previous value of 'end' here - then you'll be able to detect
any pause that happened between lines 143 and 141.


Line 147: extra_sleep_time
It would be more accurate to record the total time slept here (and the expected). The reason
is that you can't conclude the pause was only for the extra amount; the process could have
been paused for some of the sleep period as well.


Line 189: -thread
remove this, 'thread' is implied.


-- 
To view, visit http://gerrit.cloudera.org:8080/2405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04eca63c0c44fa8f1b78833080acdc2176372263
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message